Add multicore/parallel computing option#32
Open
pinusm wants to merge 6 commits intocvborkulo:masterfrom
Open
Conversation
Owner
|
This looks interesting! Will look into it. I did some updates that I haven’t uploaded here yet, so will do that first and then see if this merge still works. Thanks! |
Author
|
I see the maintainers of the package changed. Please consider the PR. It is quite straight forward to use multiple cores for parallel / independent resampling procedures. |
Collaborator
|
Hi @pinusm! Yes, @KarolineHuth and I are taking over the maintenance. Roughly, our idea is the following:
So it will be a little longer before we revisit this PR (but probably not that long). |
Author
|
Sounds like a great plan! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds quite a few dependencies, but here's a small anecdotal benchmark, using 1000 iterations, on a 5-node network, with 'ggmModSelect':
and here's the same 5-node network, using 5000 iterations, with 'EBICglasso':
I've tested this on a Windows, Ubuntu (in WSL2), and Red Hat Enterprise Linux.